Skip to content

Commit 5589f1f

Browse files
committed
move grafana_folder to annotations, simplify values.schema.json, fix #1875
Signed-off-by: Slach <[email protected]>
1 parent 3e60733 commit 5589f1f

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

deploy/helm/clickhouse-operator/values.schema.json

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -640,12 +640,7 @@
640640
"properties": {
641641
"additionalLabels": {
642642
"description": "labels to add to a secret with dashboards",
643-
"type": "object",
644-
"properties": {
645-
"grafana_dashboard": {
646-
"type": "string"
647-
}
648-
}
643+
"type": "object"
649644
},
650645
"annotations": {
651646
"description": "annotations to add to a secret with dashboards",
@@ -654,9 +649,6 @@
654649
"enabled": {
655650
"description": "provision grafana dashboards as configMaps (can be synced by grafana dashboards sidecar https://github.com/grafana/helm-charts/blob/grafana-8.3.4/charts/grafana/values.yaml#L778 )",
656651
"type": "boolean"
657-
},
658-
"grafana_folder": {
659-
"type": "string"
660652
}
661653
}
662654
},

deploy/helm/clickhouse-operator/values.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -897,7 +897,9 @@ dashboards:
897897
enabled: false
898898
# dashboards.additionalLabels -- labels to add to a secret with dashboards
899899
additionalLabels:
900+
# dashboards.additionalLabels.grafana_dashboard - will watch when official grafana helm chart sidecar.dashboards.enabled=true
900901
grafana_dashboard: ""
901902
# dashboards.annotations -- annotations to add to a secret with dashboards
902-
annotations: {}
903-
grafana_folder: clickhouse
903+
annotations:
904+
# dashboards.annotations.grafana_folder -- folder where will place dashboards, requires define values in official grafana helm chart sidecar.dashboards.folderAnnotation: grafana_folder
905+
grafana_folder: clickhouse-operator

0 commit comments

Comments
 (0)