Skip to content

Commit 6801aff

Browse files
committed
fix issue where logger in GithubAction printed messges faster than fmt.Println
1 parent 5e55b1a commit 6801aff

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ create `.licignore` in project root
2424
Install and run **GOLIC**
2525
```shell
2626
# GO 1.16
27-
go install github.com/AbsaOSS/[email protected].3
27+
go install github.com/AbsaOSS/[email protected].4
2828
golic inject -c="2021 MyCompany ltd."
2929
```
3030

cmd/inject.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ Generated by GoLic, for more details see: https://github.com/AbsaOSS/golic
1818
package cmd
1919

2020
import (
21+
"github.com/enescakir/emoji"
2122
"net/url"
2223
"os"
2324

@@ -36,15 +37,20 @@ var injectCmd = &cobra.Command{
3637
if _, err := os.Stat(injectOptions.LicIgnore); os.IsNotExist(err) {
3738
logger.Error().Msgf("invalid license path '%s'",injectOptions.LicIgnore)
3839
_ = cmd.Help()
39-
os.Exit(0)
40+
os.Exit(1)
4041
}
4142
if _,err := url.Parse(injectOptions.ConfigURL); err != nil {
4243
logger.Error().Msgf("invalid config.yaml url '%s'",injectOptions.ConfigURL)
4344
_ = cmd.Help()
44-
os.Exit(0)
45+
os.Exit(1)
4546
}
4647
i := inject.New(ctx, injectOptions)
4748
exitCode = Command(i).MustRun()
49+
if exitCode == 0 {
50+
logger.Info().Msgf("%s%s%s done", emoji.Rocket, emoji.Rocket, emoji.Rocket)
51+
} else {
52+
logger.Info().Msgf("%s exit", emoji.FaceScreamingInFear)
53+
}
4854
},
4955
}
5056

cmd/root.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ package cmd
2121
import (
2222
"context"
2323
"fmt"
24-
"github.com/enescakir/emoji"
2524
"os"
2625

2726
"github.com/AbsaOSS/golic/utils/log"
@@ -48,11 +47,6 @@ var rootCmd = &cobra.Command{
4847
}
4948
},
5049
PersistentPostRun: func(cmd *cobra.Command, args []string) {
51-
if exitCode == 0 {
52-
logger.Info().Msgf("%s%s%s done", emoji.Rocket, emoji.Rocket, emoji.Rocket)
53-
} else {
54-
logger.Info().Msgf("%s exit", emoji.FaceScreamingInFear)
55-
}
5650
os.Exit(exitCode)
5751
},
5852
}

0 commit comments

Comments
 (0)