🚑 Undefined behavior of the C language. #17

Author: ADD-SP

inc/ngx_http_waf_module_config.h

@@ -519,7 +519,7 @@ static ngx_int_t load_into_container(ngx_conf_t* cf, const char* file_name, void
                     "ngx_waf: In line %d, [%s] is not a valid IPV6 string.", line_number, ipv6.text);
                 return FAIL;
             }
-            memcpy(inx_addr.ipv6.__in6_u.__u6_addr8, ipv6.prefix, 16);
+            memcpy(inx_addr.ipv6.s6_addr, ipv6.prefix, 16);
             if (ip_trie_add((ip_trie_t*)container, &inx_addr, ipv6.suffix_num, ipv6.text) != SUCCESS) {
                 if (ip_trie_find((ip_trie_t*)container, &inx_addr, &ip_trie_node) == SUCCESS) {
                     ngx_conf_log_error(NGX_LOG_ERR, (cf), 0, 

inc/ngx_http_waf_module_ip_trie.h

@@ -170,7 +170,7 @@ static ngx_int_t ip_trie_add(ip_trie_t* trie, inx_addr_t* inx_addr, uint32_t suf
                 }
             }
             prev_node = cur_node;
-            if (CHECK_BIT(inx_addr->ipv6.__in6_u.__u6_addr8[uint8_index], 7 - (bit_index % 8)) != TRUE) {
+            if (CHECK_BIT(inx_addr->ipv6.s6_addr[uint8_index], 7 - (bit_index % 8)) != TRUE) {
                 cur_node = cur_node->left;
                 prev_bit = 0;
             } else {
@@ -191,7 +191,7 @@ static ngx_int_t ip_trie_add(ip_trie_t* trie, inx_addr_t* inx_addr, uint32_t suf
             }
         }
         uint8_index = bit_index / 8;
-        if (CHECK_BIT(inx_addr->ipv6.__in6_u.__u6_addr8[uint8_index], 7 - (bit_index % 8)) != TRUE) {
+        if (CHECK_BIT(inx_addr->ipv6.s6_addr[uint8_index], 7 - (bit_index % 8)) != TRUE) {
             cur_node->left = new_node;
         } else {
             cur_node->right = new_node;
@@ -232,7 +232,7 @@ static ngx_int_t ip_trie_find(ip_trie_t* trie, inx_addr_t* inx_addr, ip_trie_nod
     } else if (trie->ip_type == AF_INET6) {
         while (bit_index < 128 && cur_node != NULL && cur_node->is_ip != TRUE) {
             int uint8_index = bit_index / 8;
-            if (CHECK_BIT(inx_addr->ipv6.__in6_u.__u6_addr8[uint8_index], 7 - (bit_index % 8)) != TRUE) {
+            if (CHECK_BIT(inx_addr->ipv6.s6_addr[uint8_index], 7 - (bit_index % 8)) != TRUE) {
                 cur_node = cur_node->left;
             } else {
                 cur_node = cur_node->right;

inc/ngx_http_waf_module_util.h

@@ -188,7 +188,7 @@ static ngx_int_t parse_ipv6(ngx_str_t text, ipv6_t* ipv6) {
     if (inet_pton(AF_INET6, prefix_text, &addr6) != 1) {
         return FAIL;
     }
-    memcpy(prefix, &addr6.__in6_u.__u6_addr8, 16);
+    memcpy(prefix, &addr6.s6_addr, 16);
 
     uint32_t temp_suffix = 0;
     if (*c == '/') {