Skip to content

Commit df63ea4

Browse files
Deprecation warning for relay fees config (#2012)
Add deprecation warning for relay fees config and update release notes
1 parent 57bf860 commit df63ea4

File tree

3 files changed

+5
-1
lines changed

3 files changed

+5
-1
lines changed

docs/release-notes/eclair-v0.6.2.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ Relay fees are now set per node instead of per channel:
3636

3737
Note that you can use the `updaterelayfee` API *before* opening a channel to ensure that the channel doesn't use the default relay fees from `eclair.conf`.
3838

39+
The config for default fees has also be changed to allow different default fees for announced/unannounced channels: `fee-base-msat`/`fee-proportional-millionths` are now nested inside `relay.fees.public-channels`/`relay.fees.private-channels`.
40+
3941
:warning: When updating eclair, the relay fees for your existing channels will be reset to the value from your `eclair.conf`. You should use the `updaterelayfee` API to reconfigure relay fees if you don't want to use the default fees for every node you're connected to.
4042

4143
### Beta support for anchor outputs

eclair-core/src/main/scala/fr/acinq/eclair/NodeParams.scala

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,8 @@ object NodeParams extends Logging {
202202
"enable-db-backup" -> "file-backup.enabled",
203203
"backup-notify-script" -> "file-backup.notify-script",
204204
// v0.6.2
205+
"fee-base-msat" -> "relay.fees.public-channels.fee-base-msat",
206+
"fee-proportional-millionths" -> "relay.fees.public-channels.fee-proportional-millionths",
205207
"router.randomize-route-selection" -> "router.path-finding.default.randomize-route-selection",
206208
"router.path-finding.max-route-length" -> "router.path-finding.default.boundaries.max-route-length",
207209
"router.path-finding.max-cltv" -> "router.path-finding.default.boundaries.max-cltv",

eclair-core/src/test/scala/fr/acinq/eclair/integration/PaymentIntegrationSpec.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ class PaymentIntegrationSpec extends IntegrationSpec {
6565
instantiateEclairNode("D", ConfigFactory.parseMap(Map("eclair.node-alias" -> "D", "eclair.expiry-delta-blocks" -> 133, "eclair.server.port" -> 29733, "eclair.api.port" -> 28083, "eclair.trampoline-payments-enable" -> true).asJava).withFallback(commonFeatures).withFallback(commonConfig))
6666
instantiateEclairNode("E", ConfigFactory.parseMap(Map("eclair.node-alias" -> "E", "eclair.expiry-delta-blocks" -> 134, "eclair.server.port" -> 29734, "eclair.api.port" -> 28084).asJava).withFallback(withAnchorOutputsZeroFeeHtlcTxs).withFallback(commonConfig))
6767
instantiateEclairNode("F", ConfigFactory.parseMap(Map("eclair.node-alias" -> "F", "eclair.expiry-delta-blocks" -> 135, "eclair.server.port" -> 29735, "eclair.api.port" -> 28085, "eclair.trampoline-payments-enable" -> true).asJava).withFallback(withWumbo).withFallback(commonConfig))
68-
instantiateEclairNode("G", ConfigFactory.parseMap(Map("eclair.node-alias" -> "G", "eclair.expiry-delta-blocks" -> 136, "eclair.server.port" -> 29736, "eclair.api.port" -> 28086, "eclair.fee-base-msat" -> 1010, "eclair.fee-proportional-millionths" -> 102, "eclair.trampoline-payments-enable" -> true).asJava).withFallback(commonConfig))
68+
instantiateEclairNode("G", ConfigFactory.parseMap(Map("eclair.node-alias" -> "G", "eclair.expiry-delta-blocks" -> 136, "eclair.server.port" -> 29736, "eclair.api.port" -> 28086, "eclair.relay.fees.public-channels.fee-base-msat" -> 1010, "eclair.relay.fees.public-channels.fee-proportional-millionths" -> 102, "eclair.trampoline-payments-enable" -> true).asJava).withFallback(commonConfig))
6969
}
7070

7171
test("connect nodes") {

0 commit comments

Comments
 (0)