Merge branch '6.3' into 6.4

* 6.3:
  [Cache] Fix Redis6Proxy
  [Finder] Disable failing test about open_basedir
  Fix merge
  Fix merge
  [Notifier] Telegram Bridge add escaping for \
  [Routing] Fix routing collection defaults when adding a new route to a collection
  [Messenger] Fix cloned TraceableStack not unstacking the stack independently
  [DependencyInjection] Fix autocasting null env values to empty string with container.env_var_processors_locator
  [Cache] Fix support for Redis Sentinel using php-redis 6.0.0
  [Notifier] Fix Smsmode HttpClient mandatory headers
  minor #51693 Disable the dead code analysis in Psalm (stof)
  Update the PR template
  [SecurityBundle][PasswordHasher] Fix password migration with custom hasher service with security bundle config
  [Translator] Fix support for `default_path` in XML
  [FrameworkBundle] Handle tags array attributes in descriptors
  [HttpClient] Fix TraceableResponse if response has no destruct method
  [FrameworkBundle] Always use buildDir as `ConfigBuilderGenerator` outputDir

Author: nicolas-grekas

SmsmodeTransport.php

@@ -69,7 +69,10 @@ protected function doSend(MessageInterface $message): SentMessage
         }
 
         $response = $this->client->request('POST', $endpoint, [
-            'headers' => ['X-Api-Key' => $this->apiKey],
+            'headers' => [
+                'X-Api-Key' => $this->apiKey,
+                'Accept' => 'application/json',
+            ],
             'json' => array_filter($options),
         ]);
 

Tests/SmsmodeTransportTest.php

@@ -80,6 +80,27 @@ public function testNoInvalidArgumentExceptionIsThrownIfFromIsValid(string $from
         self::assertSame('foo', $sentMessage->getMessageId());
     }
 
+    public function testHttpClientHasMandatoryHeaderAccept()
+    {
+        $message = new SmsMessage('+33612345678', 'Hello!');
+
+        $response = $this->createMock(ResponseInterface::class);
+        $response->expects(self::exactly(2))->method('getStatusCode')->willReturn(201);
+        $response->expects(self::once())->method('getContent')->willReturn(json_encode(['messageId' => 'foo']));
+
+        $transport = $this->createTransport(new MockHttpClient(function (string $method, string $url, array $options) use ($response): ResponseInterface {
+            $this->assertSame('POST', $method);
+            $this->assertSame('https://rest.smsmode.com/sms/v1/messages', $url);
+            $this->assertSame('Accept: application/json', $options['normalized_headers']['accept'][0]);
+
+            return $response;
+        }), 'foo');
+
+        $result = $transport->send($message);
+
+        $this->assertSame('foo', $result->getMessageId());
+    }
+
     public static function toStringProvider(): iterable
     {
         yield ['smsmode://rest.smsmode.com?from=test_from', self::createTransport()];