Better logging message about history (#351)

aantn · web-flow · commit 7cc686133b84 · 2024-10-25T11:02:22.000+03:00
diff --git a/robusta_krr/core/runner.py b/robusta_krr/core/runner.py
@@ -218,8 +218,8 @@ async def _check_data_availability(self, cluster: Optional[str]) -> None:
         try:
             history_range = await prometheus_loader.get_history_range(timedelta(hours=5))
         except ValueError:
-            logger.warning(
-                f"Was not able to get history range for cluster {cluster}. This is not critical, will try continue."
+            logger.info(
+                f"Unable to check how much historical data is available on cluster {cluster}. Will assume it is sufficient and calculate recommendations anyway. (You can usually ignore this. Not all Prometheus compatible metric stores support checking history settings.)"
             )
             self.errors.append(
                 {

Original file line number	Diff line number	Diff line change
`@@ -218,8 +218,8 @@ async def _check_data_availability(self, cluster: Optional[str]) -> None:`
`218`	`218`	`try:`
`219`	`219`	`history_range = await prometheus_loader.get_history_range(timedelta(hours=5))`
`220`	`220`	`except ValueError:`
`221`		`- logger.warning(`
`222`		`- f"Was not able to get history range for cluster {cluster}. This is not critical, will try continue."`
	`221`	`+ logger.info(`
	`222`	`+ f"Unable to check how much historical data is available on cluster {cluster}. Will assume it is sufficient and calculate recommendations anyway. (You can usually ignore this. Not all Prometheus compatible metric stores support checking history settings.)"`
`223`	`223`	`)`
`224`	`224`	`self.errors.append(`
`225`	`225`	`{`