Skip to content

Update disk by CR edit #1834

@tiagolobocastro

Description

@tiagolobocastro

Is your feature request related to a problem? Please describe.

Updating an existing diskpool device path it tedious and dangerous as we have to edit the pstor.
There are various reasons to update the path, ex: specified the wrong disk which does not exist, or specified a disk using a non-persistent device path. Let's consider, for example, a user which has created a diskpool with /dev/sdc. They might be surprised to find that one fine day after a reboot, the pool disk is at /dev/sdb!

Describe the solution you'd like

The solution is simple: if CR updates the device path, update the device path in the pstor as well.

Additional context

Also note that once created, the control-plane would not attempt re-creation again, so even in case of a mistake we wouldn't actually write and trash another disk so we're safe from this standpoint.
In case of modifying from /dev/sdc to /dev/disk/by-id/*** we could also do additional checks to ensure the disk is correct. Since we have a disk api available via REST, the diskpool operator can easily do additional verification.

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/improvementCategorizes issue or PR as related to improving upon a current feature

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions