refactor: migrate from legacy libraries

Finishes migration from dbflow to room keeping the schema,
Also includes the jackson to moshi migration to drop reflection,
drops the last remaining usages of rxjava, and finalizes
migration from mvp to mvvm.

Author: kelsos

app/build.gradle.kts

@@ -11,7 +11,6 @@ plugins {
   alias(libs.plugins.android.application)
   alias(libs.plugins.kotlinAndroid)
   alias(libs.plugins.kotlinParcelize)
-  alias(libs.plugins.kapt)
   alias(libs.plugins.ksp)
   alias(libs.plugins.protobuf)
   alias(libs.plugins.googleServices) apply false
@@ -77,8 +76,8 @@ fun gitHash(): String {
   return "git -C $rootDir rev-parse --short HEAD".runCommand()
 }
 
-val version = "1.6.0-alpha.1"
-val code = 125
+val appVersionName = "1.6.0-alpha.1"
+val appVersionCode = 125
 
 android {
   compileSdk = 35
@@ -92,12 +91,16 @@ android {
     applicationId = "com.kelsos.mbrc"
     minSdk = 23
     targetSdk = 35
-    versionCode = code
-    versionName = version
+    versionCode = appVersionCode
+    versionName = appVersionName
     buildConfigField("String", "GIT_SHA", "\"${gitHash()}\"")
     buildConfigField("String", "BUILD_TIME", "\"${buildTime()}\"")
 
     testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
+
+    ksp {
+      arg("room.schemaLocation", "$projectDir/schemas")
+    }
   }
 
   testOptions {
@@ -191,6 +194,13 @@ android {
   }
 }
 
+
+detekt {
+  source.setFrom(files("src/main/java", "src/main/kotlin"))
+  config.setFrom(files(rootProject.file("config/detekt/detekt.yml")))
+  buildUponDefaultConfig = true
+}
+
 val dummyGoogleServicesJson: Configuration by configurations.creating {
   isCanBeResolved = true
   isCanBeConsumed = false
@@ -205,18 +215,6 @@ dependencies {
 
   implementation(projects.changelog)
 
-  testImplementation(libs.androidx.arch.core.testing)
-  testImplementation(libs.androidx.test.core)
-  testImplementation(libs.androidx.test.runner)
-  testImplementation(libs.androidx.test.junit)
-  testImplementation(libs.androidx.test.truth)
-  testImplementation(libs.bundles.androidx.test.espresso)
-  testImplementation(libs.truth)
-  testImplementation(libs.koin.test)
-  testImplementation(libs.kotlin.coroutines.test)
-  testImplementation(libs.mockk)
-  testImplementation(libs.robolectric)
-
   implementation(libs.androidx.annotation)
   implementation(libs.androidx.appcompat)
   implementation(libs.androidx.core.ktx)
@@ -229,27 +227,37 @@ dependencies {
   implementation(libs.androidx.recyclerview)
   implementation(libs.androidx.core.splashscreen)
   implementation(libs.androidx.viewpager2)
+  implementation(libs.androidx.swiperefreshlayout)
   implementation(libs.bundles.androidx.lifecycle)
-  implementation(libs.androidx.legacy.support.v4)
-  implementation(libs.androidx.legacy.support.v13)
   implementation(libs.bundles.coroutines)
+  implementation(libs.bundles.androidx.room)
   implementation(libs.bundles.coil)
   implementation(libs.bundles.koin)
   implementation(libs.google.material)
   implementation(libs.google.protobuf.javalite)
+  implementation(libs.squareup.moshi.lib)
   implementation(libs.squareup.okio)
+  implementation(libs.squareup.okhttp)
   implementation(libs.timber)
 
-  implementation(libs.bundles.dbflow)
-  implementation(libs.bundles.jackson)
-  implementation(libs.kotlin.stdlib)
-  implementation(libs.kotlin.reflect)
-  implementation(libs.rxandroid)
-  implementation(libs.rxjava)
-  implementation(libs.rxkotlin)
-  implementation(libs.rxrelay)
+  ksp(libs.androidx.room.compiler)
+  ksp(libs.squareup.moshi.codegen)
 
-  kapt(libs.dbflow.processor)
+  testImplementation(libs.androidx.arch.core.testing)
+  testImplementation(libs.androidx.room.testing)
+  testImplementation(libs.androidx.test.core)
+  testImplementation(libs.androidx.test.runner)
+  testImplementation(libs.androidx.test.junit)
+  testImplementation(libs.androidx.test.truth)
+  testImplementation(libs.bundles.androidx.test.espresso)
+  testImplementation(libs.androidx.paging.common.ktx)
+  testImplementation(libs.androidx.paging.testing)
+  testImplementation(libs.turbine)
+  testImplementation(libs.truth)
+  testImplementation(libs.koin.test)
+  testImplementation(libs.kotlin.coroutines.test)
+  testImplementation(libs.mockk)
+  testImplementation(libs.robolectric)
 
   debugImplementation(libs.squareup.leakcanary)
   debugImplementation(libs.androidx.fragment.testing)
@@ -336,7 +344,8 @@ tasks {
       }
       detekt.forEach {
         from(it.sarifReportFile) {
-          rename { "detekt.sarif" }
+          val name = it.sarifReportFile.get().asFile.nameWithoutExtension.prefixIfNot("detekt").toKebabCase()
+          rename { "$name.sarif" }
         }
       }
       from(lintReportReleaseSarifOutput) {
@@ -365,7 +374,8 @@ tasks {
     doLast {
       if (!project.file("google-services.json").exists()) {
         throw GradleException(
-          "You need a google-services.json file to run this project. Please refer to the CONTRIBUTING.md file for details."
+          "You need a google-services.json file to run this project." +
+            " Please refer to the CONTRIBUTING.md file for details."
         )
       }
     }
@@ -379,16 +389,23 @@ tasks {
   }
 }
 
-kotlin {
-  sourceSets.all {
-    languageSettings.enableLanguageFeature("ExplicitBackingFields")
-  }
-}
-
 configurations.all {
   resolutionStrategy {
     force("com.google.code.findbugs:jsr305:3.0.2")
     force("org.jetbrains.kotlin:kotlin-stdlib-jdk8:${project.libs.versions.kotlin.get()}")
     force("org.jetbrains.kotlin:kotlin-reflect:${project.libs.versions.kotlin.get()}")
   }
 }
+
+
+fun String.toKebabCase(): String {
+  return this.trim()
+    .replace(Regex("([a-z])([A-Z])"), "$1-$2")
+    .replace(Regex("[\\s_]+"), "-")
+    .replace(Regex("[^a-zA-Z0-9-]"), "")
+    .lowercase()
+}
+
+fun String.prefixIfNot(prefix: String): String {
+  return if (this.startsWith(prefix)) this else "$prefix-$this"
+}

app/proguard-rules.pro

@@ -46,94 +46,14 @@
     public static *** v(...);
 }
 
-
-# Proguard configuration for Jackson 2.x (fasterxml package instead of codehaus package)
-
--keep class com.fasterxml.jackson.databind.ObjectMapper {
-    public <methods>;
-    protected <methods>;
-}
--keep class com.fasterxml.jackson.databind.ObjectWriter {
-    public ** writeValueAsString(**);
-}
-
-## Retrolambda specific rules ##
-
 # as per official recommendation: https://github.com/evant/gradle-retrolambda#proguard
 -dontwarn java.lang.invoke.*
 
-
-# rxjava
--keep class rx.schedulers.Schedulers {
-    public static <methods>;
-}
--keep class rx.schedulers.ImmediateScheduler {
-    public <methods>;
-}
--keep class rx.schedulers.TestScheduler {
-    public <methods>;
-}
--keep class rx.schedulers.Schedulers {
-    public static ** test();
-}
--keepclassmembers class rx.internal.util.unsafe.*ArrayQueue*Field* {
-    long producerIndex;
-    long consumerIndex;
-}
--keepclassmembers class rx.internal.util.unsafe.BaseLinkedQueueProducerNodeRef {
-    long producerNode;
-    long consumerNode;
-}
-
-# DBFlow
--keep class * extends com.raizlabs.android.dbflow.config.DatabaseHolder { *; }
--keep class com.raizlabs.android.dbflow.config.GeneratedDatabaseHolder
--keep class * extends com.raizlabs.android.dbflow.config.BaseDatabaseDefinition { *; }
-
 ## OKHttp ##
 
 -dontwarn com.squareup.okhttp.**
 
-
-# AppCompat v7
--keep public class android.support.v7.widget.** { *; }
--keep public class android.support.v7.internal.widget.** { *; }
--keep public class android.support.v7.internal.view.menu.** { *; }
-
--keep public class * extends android.support.v4.view.ActionProvider {
-    public <init>(android.content.Context);
-}
-
-# Support Design
--dontwarn android.support.design.**
--keep class android.support.design.** { *; }
--keep interface android.support.design.** { *; }
--keep public class android.support.design.R$* { *; }
-
-
--dontwarn com.fasterxml.jackson.databind.ext.**
--dontwarn rx.internal.util.unsafe.**
-
-### Jackson SERIALIZER SETTINGS
--keepclassmembers class * {
-    @com.fasterxml.jackson.annotation.* <fields>;
-    @com.fasterxml.jackson.annotation.* <init>(...);
-}
-
-# Jackson
--dontskipnonpubliclibraryclassmembers
--keepattributes *Annotation*,EnclosingMethod,Signature
--keepnames class com.fasterxml.jackson.** { *; }
--dontwarn com.fasterxml.jackson.databind.**
-
-# Keep anything annotated with @JsonCreator
--keepclassmembers public class * {
-    @com.fasterxml.jackson.annotation.JsonCreator *;
-    @com.fasterxml.jackson.annotation.JsonProperty *;
-}
-
 -keep class kotlin.** { *; }
--keep class com.raizlabs.android.dbflow.structure.Model { *; }
 
 -keep class com.kelsos.mbrc.** {
     void set*(***);