Skip to content

Should e37cf98's addition of -r FreeBSD to the update cmd also have been added to the following, related rquery? #1227

@markmi

Description

@markmi

Prerequisites

  • Have you checked for an existing issue describing the issue?

This is more of a question if e37cf98 was incomplete, prompted by a question on discord that lead to me looking at the code. It added the -r FreeBSD in:

	if ! JNETNAME="n" injail env ASSUME_ALWAYS_YES=yes \
	    PACKAGESITE="${packagesite:?}" \
	    ${pkg_bin} update -f -r FreeBSD; then
		msg "Package fetch: Not fetching as remote repository is unavailable."
		rm -f "${missing_pkgs}"
		return 0
	fi

The following code is:

	# Don't trust pkg-update to return its error
	if ! injail ${pkg_bin} rquery -U %n pkg >/dev/null; then
		msg "Package fetch: Failed to fetch package repository."
		rm -f "${missing_pkgs}"
		return 0
	fi

Should the rquery also have a -r FreeBSD to match?

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions