6.6-lts does not compile LINT

[bzfbd]

Can we please make sure a universe with drm-kmod can pass? In this case it is 6.6-lts

--------------------------------------------------------------
>>> stage 3.1: building everything
--------------------------------------------------------------
/tank/users/bz/local_modules_dir/drm-kmod/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c:926:2: error: call to undeclared function 'AcpiUtStatusExit'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
  926 |         return_ACPI_STATUS(AE_NOT_EXIST);
      |         ^
/tank/users/bz/git/FreeBSD/freebsd-src/sys/contrib/dev/acpica/include/acoutput.h:549:22: note: expanded from macro 'return_ACPI_STATUS'
  549 |     ACPI_TRACE_EXIT (AcpiUtStatusExit, ACPI_STATUS, Status)
      |                      ^
/tank/users/bz/local_modules_dir/drm-kmod/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c:926:2: error: use of undeclared identifier '_AcpiModuleName'
/tank/users/bz/git/FreeBSD/freebsd-src/sys/contrib/dev/acpica/include/acoutput.h:549:5: note: expanded from macro 'return_ACPI_STATUS'
  549 |     ACPI_TRACE_EXIT (AcpiUtStatusExit, ACPI_STATUS, Status)
      |     ^
/tank/users/bz/git/FreeBSD/freebsd-src/sys/contrib/dev/acpica/include/acoutput.h:526:19: note: expanded from macro 'ACPI_TRACE_EXIT'
  526 |         Function (ACPI_DEBUG_PARAMETERS, _Param); \
      |                   ^
/tank/users/bz/git/FreeBSD/freebsd-src/sys/contrib/dev/acpica/include/acoutput.h:407:39: note: expanded from macro 'ACPI_DEBUG_PARAMETERS'
  407 |     __LINE__, ACPI_GET_FUNCTION_NAME, _AcpiModuleName, _COMPONENT
      |                                       ^
/tank/users/bz/local_modules_dir/drm-kmod/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c:926:2: error: use of undeclared identifier '_COMPONENT'
/tank/users/bz/git/FreeBSD/freebsd-src/sys/contrib/dev/acpica/include/acoutput.h:549:5: note: expanded from macro 'return_ACPI_STATUS'
  549 |     ACPI_TRACE_EXIT (AcpiUtStatusExit, ACPI_STATUS, Status)
      |     ^
/tank/users/bz/git/FreeBSD/freebsd-src/sys/contrib/dev/acpica/include/acoutput.h:526:19: note: expanded from macro 'ACPI_TRACE_EXIT'
  526 |         Function (ACPI_DEBUG_PARAMETERS, _Param); \
      |                   ^
/tank/users/bz/git/FreeBSD/freebsd-src/sys/contrib/dev/acpica/include/acoutput.h:407:56: note: expanded from macro 'ACPI_DEBUG_PARAMETERS'
  407 |     __LINE__, ACPI_GET_FUNCTION_NAME, _AcpiModuleName, _COMPONENT
      |                                                        ^
3 errors generated.
--- amdgpu_acpi.o ---
*** [amdgpu_acpi.o] Error code 1
 
make[8]: stopped in /tank/users/bz/local_modules_dir/drm-kmod/amd/amdgpu
--- all_subdir_drm-kmod/amd/amdgpu ---
 
make[7]: stopped in /tank/users/bz/local_modules_dir/drm-kmod/amd
--- all_subdir_drm-kmod/amd ---
 
make[6]: stopped in /tank/users/bz/local_modules_dir/drm-kmod
--- modules-all ---
*** [modules-all] Error code 1

[bzfbd]

The problem is that FreeBSD LINT kernels set ACPI_DEBUG on x86.
That in turn enables ACPI_DEBUG_OUTPUT which enables tracing.
amdgpu does not set the necessary bits and in addition there is a problem with AcpiUtStatusExit not being exported but used by return_ACPI_STATUS() from acpica.

A hackish solution which allows make universe to pass for amd64,arm64,i386 would be:

diff --git drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
index 9e7bcbcae7..cab602b99a 100644
--- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
+++ drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
@@ -901,6 +901,15 @@ static struct amdgpu_numa_info *amdgpu_acpi_get_numa_info(uint32_t pxm)
  *
  * Returns ACPI STATUS OK with Node ID on success or the corresponding failure reason
  */
+#if defined(__FreeBSD__)
+#include "opt_acpi.h"
+
+#ifdef ACPI_DEBUG
+void AcpiUtStatusExit(UINT32, const char *, const char *, UINT32, ACPI_STATUS);
+ACPI_MODULE_NAME("AMDGPU")
+#define        _COMPONENT      ACPI_HARDWARE
+#endif
+#endif
 static acpi_status amdgpu_acpi_get_node_id(acpi_handle handle,
                                    struct amdgpu_numa_info **numa_info)
 {