Skip to content

Agent Build intentionally broken #252

@Vadim2S

Description

@Vadim2S

This is hilarious but:

Agent build docker container and commit it with /clearml_agent/helper/process.py commit_docker function.

def commit_docker(container_name, docker_cmd_contains=None, docker_id=None, apply_change=None):       
...
   output = get_bash_output(cmd='docker commit {} {} {}'.format(apply_change, docker_id, container_name)) 

Command line like "docker commit --change " at first glace all OK. But!

Container name (rather "repository" as docker doc says) = target and /clearml_agent/commands/worker.py build function has code

        if target and not os.path.isabs(target):
            # Non absolute target path will lead to errors with relative python executable
            target = os.path.abspath(target)

i.e repository name intentionally extended to path like "my_image" -> "/home/user/ClearML_RD/Project1/my_image" :-)

Off course name with CAPS do not work with docker and build fail. With error "None" - see next bug report :-)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions