Skip to content

Commit 17853a9

Browse files
yannikmesserligeakstr
authored andcommitted
Add traffic direction cell
Signed-off-by: Yannik Messerli <[email protected]>
1 parent e45f178 commit 17853a9

File tree

5 files changed

+23
-1
lines changed

5 files changed

+23
-1
lines changed

src/components/FlowsTable/Cell.tsx

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,13 @@ export const Cell = observer(function FlowsTableCell(props: CellProps) {
109109
</div>
110110
);
111111
}
112+
case Column.TrafficDirection: {
113+
return (
114+
<div className={classnames(css.cell, css.trafficDirection)}>
115+
{props.flow.trafficDirectionLabel}
116+
</div>
117+
);
118+
}
112119
case Column.Verdict: {
113120
const className = classnames(css.cell, css.verdict, {
114121
[css.forwardedVerdict]: props.flow.verdict === Verdict.Forwarded,

src/components/FlowsTable/Header.tsx

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,11 @@ export const Header = memo<CommonProps>(function FlowsTableHeader(props) {
3232
{props.visibleColumns.has(Column.L7Info) && (
3333
<div className={classnames(css.cell, css.l7info)}>{getColumnLabel(Column.L7Info)}</div>
3434
)}
35+
{props.visibleColumns.has(Column.TrafficDirection) && (
36+
<div className={classnames(css.cell, css.trafficDirection)}>
37+
{getColumnLabel(Column.TrafficDirection)}
38+
</div>
39+
)}
3540
{props.visibleColumns.has(Column.Verdict) && (
3641
<div className={classnames(css.cell, css.verdict)}>{getColumnLabel(Column.Verdict)}</div>
3742
)}

src/components/FlowsTable/Row.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,9 @@ export const Row = memo<RowProps>(function FlowsTableRow(props) {
6161
)}
6262
{props.visibleColumns.has(Column.DstPort) && <Cell flow={props.flow} kind={Column.DstPort} />}
6363
{props.visibleColumns.has(Column.L7Info) && <Cell flow={props.flow} kind={Column.L7Info} />}
64+
{props.visibleColumns.has(Column.TrafficDirection) && (
65+
<Cell flow={props.flow} kind={Column.TrafficDirection} />
66+
)}
6467
{props.visibleColumns.has(Column.Verdict) && <Cell flow={props.flow} kind={Column.Verdict} />}
6568
{props.visibleColumns.has(Column.Auth) && <Cell flow={props.flow} kind={Column.Auth} />}
6669
{props.visibleColumns.has(Column.TcpFlags) && (

src/components/FlowsTable/__tests__/Row.test.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,9 @@ const runTest = (ntest: number, hf: HubbleFlow, exps: Expectations) => {
8686
row = renderRow(
8787
<Row
8888
flow={flow}
89-
visibleColumns={new Set(Object.values(Column))}
89+
visibleColumns={
90+
new Set(Object.values(Column).filter(f => f !== Column.TrafficDirection))
91+
}
9092
isSelected={selected}
9193
onSelect={onSelect}
9294
></Row>,

src/components/FlowsTable/styles.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,11 @@
7878
text-align: right;
7979
}
8080

81+
&.trafficDirection {
82+
max-width: 130px;
83+
text-align: right;
84+
}
85+
8186
&.verdict {
8287
max-width: 130px;
8388
}

0 commit comments

Comments
 (0)