Adding option to set tolerations when executing `cilium connectivity test`

[oshothebig]

Proposal / RFE

Is your feature request related to a problem?

cilium connectivity test doesn't have a way to set tolerations or ignore all kinds of taints. It's inconvenient for our cluster where all nodes have at least one taint as cilium connectivity test creates pods without tolerations resulting in the test not being started.

Describe the solution you'd like
Add an CLI option in cilium connectivity test

• to set tolerations, or
• to ignore all taints

[gsstuart]

It looks like this feature has been added to the 0.18.5 release of cilium-cli 🥳

[Th3D0ct0r]

It looks like its applied to almost all workloads in the connectivity test except host-netns. Any reason why its not applied there?

This is missing tolerations and a nodeselector/nodeaffinity

cilium-cli/vendor/github.com/cilium/cilium/cilium-cli/connectivity/check/deployment.go

Lines 1094 to 1102 in 024e340

	ct.Logf("✨ [%s] Deploying %s daemonset...", hostNetNSDeploymentName, client.ClusterName())
	ds := newDaemonSet(daemonSetParameters{
	Name: hostNetNSDeploymentName,
	Kind: kindHostNetNS,
	Image: ct.params.CurlImage,
	Labels: map[string]string{"other": "host-netns"},
	Command: []string{"/usr/bin/pause"},
	HostNetwork: true,
	})