Replace Chi with Standard Library

Preserve existing behavior and ease maintenance by reducing external
dependencies.

- Create custom router (`CustomServeMux`) to replace `go-chi/chi/v5`. Also,
  replace the few middlewares to eliminate other Chi imports.
- Implement `bat-go` style error handling without a dependency using `AppError`
  type and handler
- Consolidate routing to make it easier to understand the whole
  interface in one place.

Author: Sneagan

Makefile

@@ -6,7 +6,7 @@ docker-dev:
 
 docker-test:
 	docker compose -f docker-compose.yml -f docker-compose.dev.yml run --rm -p 2416:2416 challenge-bypass bash -c \
-	"(aws dynamodb delete-table \
+	"export AWS_PAGER='' && (aws dynamodb delete-table \
 	--table-name redemptions --endpoint-url http://dynamodb:8000 --region us-west-2  || \
 	aws dynamodb create-table \
 	--attribute-definitions AttributeName=id,AttributeType=S \

go.mod

@@ -11,8 +11,6 @@ require (
 	github.com/brave-intl/bat-go/libs v0.0.0-20250515184320-890ea7676fc7
 	github.com/brave-intl/challenge-bypass-ristretto-ffi v0.0.0-20220418231828-419995e4a873
 	github.com/getsentry/raven-go v0.2.0
-	github.com/go-chi/chi/v5 v5.2.2
-	github.com/go-chi/httplog/v3 v3.2.2
 	github.com/golang-migrate/migrate/v4 v4.18.3
 	github.com/google/uuid v1.6.0
 	github.com/jmoiron/sqlx v1.3.5
@@ -23,7 +21,7 @@ require (
 	github.com/satori/go.uuid v1.2.0
 	github.com/segmentio/kafka-go v0.4.38
 	github.com/segmentio/kafka-go/sasl/aws_msk_iam_v2 v0.1.0
-	github.com/stretchr/testify v1.9.0
+	github.com/stretchr/testify v1.10.0
 )
 
 require (

go.sum

@@ -102,10 +102,6 @@ github.com/getsentry/sentry-go v0.17.0 h1:UustVWnOoDFHBS7IJUB2QK/nB5pap748ZEp0sw
 github.com/getsentry/sentry-go v0.17.0/go.mod h1:B82dxtBvxG0KaPD8/hfSV+VcHD+Lg/xUS4JuQn1P4cM=
 github.com/go-chi/chi v4.1.2+incompatible h1:fGFk2Gmi/YKXk0OmGfBh0WgmN3XB8lVnEyNz34tQRec=
 github.com/go-chi/chi v4.1.2+incompatible/go.mod h1:eB3wogJHnLi3x/kFX2A+IbTBlXxmMeXJVKy9tTv1XzQ=
-github.com/go-chi/chi/v5 v5.2.2 h1:CMwsvRVTbXVytCk1Wd72Zy1LAsAh9GxMmSNWLHCG618=
-github.com/go-chi/chi/v5 v5.2.2/go.mod h1:L2yAIGWB3H+phAw1NxKwWM+7eUH/lU8pOMm5hHcoops=
-github.com/go-chi/httplog/v3 v3.2.2 h1:G0oYv3YYcikNjijArHFUlqfR78cQNh9fGT43i6StqVc=
-github.com/go-chi/httplog/v3 v3.2.2/go.mod h1:N/J1l5l1fozUrqIVuT8Z/HzNeSy8TF2EFyokPLe6y2w=
 github.com/go-errors/errors v1.4.2 h1:J6MZopCL4uSllY1OfXM374weqZFFItUbrImctkmUxIA=
 github.com/go-errors/errors v1.4.2/go.mod h1:sIVyrIiJhuEF+Pj9Ebtd6P/rEYROXFi3BopGUQ5a5Og=
 github.com/go-logr/logr v1.4.2 h1:6pFjapn8bFcIbiKo3XT4j/BhANplGihG6tvd+8rYgrY=
@@ -254,8 +250,8 @@ github.com/stretchr/testify v1.6.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/
 github.com/stretchr/testify v1.7.0/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
 github.com/stretchr/testify v1.7.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
 github.com/stretchr/testify v1.8.0/go.mod h1:yNjHg4UonilssWZ8iaSj1OCr/vHnekPRkoO+kdMU+MU=
-github.com/stretchr/testify v1.9.0 h1:HtqpIVDClZ4nwg75+f6Lvsy/wHu+3BoSGCbBAcpTsTg=
-github.com/stretchr/testify v1.9.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
+github.com/stretchr/testify v1.10.0 h1:Xv5erBjTwe/5IxqUQTdXv5kgmIvbHo3QQyRwhJsOfJA=
+github.com/stretchr/testify v1.10.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
 github.com/throttled/throttled/v2 v2.12.0 h1:IezKE1uHlYC/0Al05oZV6Ar+uN/znw3cy9J8banxhEY=
 github.com/throttled/throttled/v2 v2.12.0/go.mod h1:+EAvrG2hZAQTx8oMpBu8fq6Xmm+d1P2luKK7fIY1Esc=
 github.com/xdg/scram v1.0.5 h1:TuS0RFmt5Is5qm9Tm2SoD89OPqe4IRiFtyFY4iwWXsw=

main.go

@@ -28,7 +28,7 @@ func main() {
 		Commit    = "none"
 	)
 
-	serverCtx, logger := server.SetupLogger(context.Background(), Version, BuildTime, Commit)
+	logger := server.SetupLogger(Version, BuildTime, Commit)
 	srv := *server.DefaultServer
 	srv.Logger = logger
 
@@ -90,7 +90,7 @@ func main() {
 	}
 
 	logger.Debug("Initializing API server")
-	err = srv.ListenAndServe(serverCtx, logger)
+	err = srv.ListenAndServe(logger)
 	if err != nil {
 		logger.Error("listenandserve", slog.Any("error", err))
 		raven.CaptureErrorAndWait(err, nil)

server/app_handler.go

@@ -0,0 +1,68 @@
+package server
+
+import (
+	"encoding/json"
+	"fmt"
+	"log/slog"
+	"net/http"
+)
+
+// AppError defines an application error with cause, message and HTTP status code
+type AppError struct {
+	Cause   error  `json:"-"`
+	Message string `json:"message"`
+	Code    int    `json:"-"`
+}
+
+// Error returns the error message
+func (e *AppError) Error() string {
+	if e.Cause != nil {
+		return fmt.Sprintf("%s: %s", e.Message, e.Cause.Error())
+	}
+	return e.Message
+}
+
+// WrapError creates a new AppError from an error
+func WrapError(err error, message string, code int) *AppError {
+	return &AppError{
+		Cause:   err,
+		Message: message,
+		Code:    code,
+	}
+}
+
+// RenderContent renders JSON content with appropriate status code
+func RenderContent(content any, w http.ResponseWriter, statusCode int) error {
+	w.Header().Set("Content-Type", "application/json; charset=utf-8")
+	w.WriteHeader(statusCode)
+	if content == nil {
+		// Return empty JSON object instead of null
+		_, err := w.Write([]byte("{}"))
+		return err
+	}
+	return json.NewEncoder(w).Encode(content)
+}
+
+// AppHandler is a custom HTTP handler type that returns an AppError
+type AppHandler func(http.ResponseWriter, *http.Request) *AppError
+
+// ServeHTTP makes AppHandler satisfy the http.Handler interface
+func (fn AppHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
+	if err := fn(w, r); err != nil {
+		// Log the error
+		if logger, ok := r.Context().Value("logger").(*slog.Logger); ok && err.Cause != nil {
+			logger.Error("handler error",
+				slog.String("message", err.Message),
+				slog.Any("error", err.Cause))
+		}
+		// Render the error response
+		w.Header().Set("Content-Type", "application/json; charset=utf-8")
+		w.WriteHeader(err.Code)
+		// Create the error response
+		errorResponse := map[string]string{"message": err.Message}
+		if err := json.NewEncoder(w).Encode(errorResponse); err != nil {
+			// If we can't encode the error response, log it and send a plain text error
+			http.Error(w, "Internal Server Error", http.StatusInternalServerError)
+		}
+	}
+}

server/db.go

@@ -7,6 +7,7 @@ import (
 	"fmt"
 	"log/slog"
 	"os"
+	"strconv"
 	"time"
 
 	"github.com/brave-intl/challenge-bypass-server/model"
@@ -63,9 +64,9 @@ type RedemptionV2 struct {
 
 // CacheInterface cache functions
 type CacheInterface interface {
-	Get(k string) (interface{}, bool)
+	Get(k string) (any, bool)
 	Delete(k string)
-	SetDefault(k string, x interface{})
+	SetDefault(k string, x any)
 }
 
 var (
@@ -80,6 +81,51 @@ func (c *Server) LoadDBConfig(config DBConfig) {
 	c.dbConfig = config
 }
 
+// InitDBConfig reads os environment and update conf
+func (c *Server) InitDBConfig() error {
+	conf := DBConfig{
+		DefaultDaysBeforeExpiry: 7,
+		DefaultIssuerValidDays:  30,
+		MaxConnection:           100,
+	}
+	// Heroku style
+	if connectionURI := os.Getenv("DATABASE_URL"); connectionURI != "" {
+		conf.ConnectionURI = os.Getenv("DATABASE_URL")
+	}
+	if dynamodbEndpoint := os.Getenv("DYNAMODB_ENDPOINT"); dynamodbEndpoint != "" {
+		conf.DynamodbEndpoint = os.Getenv("DYNAMODB_ENDPOINT")
+	}
+	if maxConnection := os.Getenv("MAX_DB_CONNECTION"); maxConnection != "" {
+		if count, err := strconv.Atoi(maxConnection); err == nil {
+			conf.MaxConnection = count
+		}
+	}
+	if defaultDaysBeforeExpiry := os.Getenv("DEFAULT_DAYS_BEFORE_EXPIRY"); defaultDaysBeforeExpiry != "" {
+		if count, err := strconv.Atoi(defaultDaysBeforeExpiry); err == nil {
+			conf.DefaultDaysBeforeExpiry = count
+		}
+	}
+	if defaultIssuerValidDays := os.Getenv("DEFAULT_ISSUER_VALID_DAYS"); defaultIssuerValidDays != "" {
+		if count, err := strconv.Atoi(defaultIssuerValidDays); err == nil {
+			conf.DefaultIssuerValidDays = count
+		}
+	}
+	if cacheEnabled := os.Getenv("CACHE_ENABLED"); cacheEnabled == "true" {
+		cachingConfig := CachingConfig{
+			Enabled:       true,
+			ExpirationSec: 10,
+		}
+		if cacheDurationSecs := os.Getenv("CACHE_DURATION_SECS"); cacheDurationSecs != "" {
+			if secs, err := strconv.Atoi(cacheDurationSecs); err == nil {
+				cachingConfig.ExpirationSec = secs
+			}
+		}
+		conf.CachingConfig = cachingConfig
+	}
+	c.LoadDBConfig(conf)
+	return nil
+}
+
 // InitDB initialzes the database connection based on a server's configuration
 func (c *Server) InitDB() {
 	cfg := c.dbConfig