waitdelay property sign has no effect on trains

[HightechTR]

Info

Please provide the following information:

• BkCommonLib Version (/train version): 1.20.6-v1
• TrainCarts Version (/train version): 1.20.6-v1
• Server Type and Version (/version): Paper 1.20.6

---

Bug

The property sign does not change the wait.delay property of trains as intended.

Description

The waitdelay property sign should modify the waitdelay property of trains.
However, in my testing, it does not have any effect on the train at all.

Expected behaviour

The sign should change the train's wait delay to the amount defined on the sign.
E.g., a waitdelay property sign with the number set to 5 should change the train's wait delay to 5 seconds.

Actual behaviour

The sign does not have any effect on the train, even when using an always-on power mode [+train].
The train retains the same wait delay it has previously set.

Steps to reproduce

For a wait delay of 5 seconds:
Build a waitdelay property sign with the following format:

[+train]
property
waitdelay
5

Have a train run over the sign.

[bergerkiller]

It works for me, but maybe its not fully clear what the wait delay does. With a wait delay set, if the train is put to a complete stop (not if its moving super slowly following another train), then before starting to move again it waits this delay.

How did you expect the wait delay to function?

What I tested:

I spawned a train with a wait distance set, delay 0, then a waitdelay property sign sets it to 5. Now when the train is stopped by a still-standing train, and I destroy that still-standing train, it waits for the $waitdelay before starting to move again.

[HightechTR]

That is exactly how I expected the wait delay to function.
For whatever reason, when I tested it, the waitdelay property sign does not do anything.
I even selected the train and ran /train property wait delay to check, and indeed the sign did not change the wait delay.

[bergerkiller]

Was the placement correct, so that the train is facing the sign (direction?). You can use [+train:*] to activate from any direction

[HightechTR]

The sign was placed on the side of the block the rails are on, so the train sees the side of the sign. This should be a correct placement as far as I know.

[bergerkiller]

Can you include a screenshot? It sounds correct yes. Still worth checking if the * makes a difference

[HightechTR]

This was the setup I had:

The sign was lined up with a bunch of other property signs (the others all work by the way).

I had a train run over it, then I ran /train wait delay to check it's wait delay, instead of 5 it was 20:

I don't even know where the 20 came from, since I did not set the number 20 in the DefaultTrainProperties config at all.

I also tried with the *, sadly it did not make any difference.

As a hunch, I decided to place another waitdelay sign further down the track just by itself:

This time, it actually worked:

Not sure what is going on here but at least I made progress.

[bergerkiller]

The 20 came from the waitacceleration sign, and without your screenshots I never wouldve figured that out haha

Thanks, this should fix it

https://ci.mg-dev.eu/job/TrainCarts/1600/

[HightechTR]

Looks good, though I sadly can't test it right now since its a build for 1.21, and our server can't update to that until all our plugins are updated.

[bergerkiller]

Builds 1.21 work on older server versions