Skip to content

Incomplete reposFilter implementation in Applications list #24040

@choejwoo

Description

@choejwoo

Summary

While working on #24038, I came across a part of the code that raised some questions, so I opened an issue about it.

There’s a variable called reposFilter used in the Application dashboard code, which seems to be intended for filtering applications by repository.
However, as far as I can tell, there doesn’t seem to be any logic or UI component that actually uses this filter.
Could this code be unnecessary?

Motivation

Specifically, the backend logic for filtering applications by repository exists, but the corresponding frontend UI component and URL parameter handling are missing.

reposFilter

https://github.com/argoproj/argo-cd/blob/master/ui/src/app/applications/components/applications-list/applications-filter.tsx#L35
repos: pref.reposFilter.length === 0 || pref.reposFilter.includes(getAppDefaultSource(app).repoURL),

https://github.com/argoproj/argo-cd/blob/master/ui/src/app/applications/components/applications-list/applications-filter.tsx#L278
There is no repoFilter component in ApplicationsFilter

Proposal

If there are no plans to fully implement this feature, I believe it would be best to remove the partially implemented code related to reposFilter.
If there’s any use case or component that I might have missed where reposFilter is actually needed, please let me know. I’ll close the issue accordingly.

If it’s decided that the partial implementation should be cleaned up, feel free to assign the issue to me. I’d be happy to take care of it.
Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    component:uiUser interfaces bugs and enhancementsenhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions