fflib_SObjectSelectorTest Error: 'Assertion Failed: Expected: 12345.67, Actual: 9117.25'

[adayIvey]

Describe the bug
when I run the tests in 'fflib_SObjectSelectorTest Class' I get the following error.

System.AssertException: Assertion Failed: Expected: 12345.67, Actual: 9117.25
CODE LINE: system.assertEquals(12345.67,result[0].AnnualRevenue);

I think this has to do with our org being multi currency and there is a conversion being applied on all currency fields in the Account object

To Reproduce

Run test 'fflib_SObjectSelectorTest' from Developer Console in salesforce in a multi currency org

Expected behavior
All tests in class 'fflib_SObjectSelectorTest' pass and can handle currency correctly

Version
I just installed the latest version

[adayIvey]

Setting the CurrencyIsoCode = 'USD' when the account data is created in the test fixed the issue for me

List accountList = new List
{
new Account(Name='TestAccount2',AccountNumber='A2',AnnualRevenue=12345.67, CurrencyIsoCode = 'USD'),
new Account(Name='TestAccount1',AccountNumber='A1',AnnualRevenue=76543.21, CurrencyIsoCode = 'USD')
};

[ImJohnMDaniel]

Thanks for the update @adayIvey. Glad to hear that you were able to resolve your issue. Cheers!

[adayIvey]

While I did resolve my issue I think the test should be updated to include a currency code when creating Account Data

[john-storey-devops]

Sounds like a reasonable and simple test improvement that would shield users from a nuisance test failure.

[john-storey-devops]

Hi @adayIvey,
I'm having difficulty reproducing your issue. Would you, please, send me a screenshot of your Manage Currencies page so that I recreate that in a scratch org?

[adayIvey]

***@***.*** ***@***.*** From: John Storey ***@***.***> Sent: Wednesday, June 12, 2024 7:30 PM To: apex-enterprise-patterns/fflib-apex-common ***@***.***> Cc: Day, Andrew ***@***.***>; Mention ***@***.***> Subject: Re: [apex-enterprise-patterns/fflib-apex-common] fflib_SObjectSelectorTest Error: 'Assertion Failed: Expected: 12345.67, Actual: 9117.25' (Issue #489) External email: Only click links and attachments from recognized senders. Contact IT if you are unsure. Hi @adayIvey<https://github.com/adayIvey>, I'm having difficulty reproducing your issue. Would you, please, send me a screenshot of your Manage Currencies page so that I recreate that in a scratch org? - Reply to this email directly, view it on GitHub<#489 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADXEGU7JPBH5G5CDSUJPPE3ZHDKY3AVCNFSM6AAAAABJHD4AM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRUGA3DCMJUHE>. You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>

[john-storey-devops]

Hi again @adayIvey,
For some reason, your reply came through unreadable. Here's what I see on the Github site.

[adayIvey]

[john-storey-devops]

@adayIvey
I created a scratch org from this project's multi-currency definition and configured as depicted above, yet all FFLIB tests complete and pass.

Are there other multicurrency configurations that might help me to reproduce the issue that you're seeing? It's obvious you're experiencing something; we just need to identify the culprit for reproducibility.

Thanks!