Custom strategies - Disable Create and/or Edit

[juliomariano-hotmart]

Describe the feature request

Hello!

Considering that custom strategies are deprecated, I would like to have the possibility (as Admin) of disabling the creation of new ones and also the possibility of blocking the editing of existing custom strategies.

This would allow applications to start using the predefined strategies.

Background

This feature would help prevent new custom strategies from being created or edited. It would prevent the propagation and expansion of a deprecated feature.

It would help in the future migration process to a Major where custom strategies do not exist.

Solution suggestions

It could look like the Maintenance Mode functionality but for a deprecated functionality, like custom strategies.

• Enable/Disable the creation of new Custom Strategies
• Enable/Disable the editing of new Custom Strategies
• Log as WARN in the applications about the use of custom strategies

[gastonfournier]

Hi @juliomariano-hotmart we've taken into consideration the feedback received after deprecating custom strategies and we believe it'll be valuable to keep them for very specific advanced cases. Most can be solved with pre-defined strategies and should be the default go-to option, but maybe there's value on allowing users to disable them or disable its creation. Maybe a permissions would work fine for this purpose, as it would allow you as admin to disable creation/edition of them.

It would help in the future migration process to a Major where custom strategies do not exist.

From the feedback collected, we think they're going to stay, but they should only be valid in server side SDKs, not the frontend. This is an area we're still exploring trying to come up with a good solution, but is susceptible of change.

[juliomariano-hotmart]

Hello @gastonfournier , thanks for the reply!

I believe that having this possibility, as an admin, to block or enable the creation of new Custom Strategies will be a great feature to prevent new toggles from coming with this deprecated feature.

We can actually see that the custom strategy can be easily transformed into the pre-defined with a few adjustments. However, until the developers see this, I believe that having a way to block the creation and editing will force the adoption of the new way of creating these strategies.

I'm still following the issue. Thanks for the feedback and count on me for testing

[gastonfournier]

Hi @juliomariano-hotmart we have a set of permissions targeting directly to custom strategies:

• CREATE_STRATEGY
• UPDATE_STRATEGY: this allows you also to deactivate and reactivate strategies
• DELETE_STRATEGY

In the UI they show as follows:

Let me know if this works for you

[juliomariano-hotmart]

I believe it works @gastonfournier but I didn't find this option in the interface (as Admin).
Would it only be for the paid versions of the tool? Or would it be something you're going to release?

[gastonfournier]

Hi @juliomariano-hotmart yes, this is part of an enterprise feature: https://docs.getunleash.io/how-to/how-to-create-and-assign-custom-root-roles

We're discussing if it makes sense to allow users to edit the existing pre-defined roles as for this use case it might be useful.

[juliomariano-hotmart]

@gastonfournier Is it possible to open this feature to the free version? Since when the feature stops existing it will affect all versions (Free or Enterprise)

Today we use the self-hosted version

[gastonfournier]

Hi @juliomariano-hotmart we were talking about this and one possibility could be to include an environment variable to specifically disable the creation or edition of custom strategies. For the existing ones we consider it's better to keep using them as we don't want this to cause any misbehavior on the SDKs. Would that option be good enough for your use case?