Skip to content

Commit dae0746

Browse files
committed
Update tests for matrix
1 parent d8dee9d commit dae0746

File tree

2 files changed

+16
-3
lines changed

2 files changed

+16
-3
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
- name: Upload
3737
if: ${{ github.repository_owner == 'Slimefun' && github.ref == 'refS/heads/main' }}
3838
run: |
39-
curl -v -X POST \
39+
curl -X POST \
4040
-H 'Authorization: ${{ secrets.PUBLISH_TOKEN }}' \
4141
-H "X-Checksum: $(sha256sum target/e2e-test-plugin.jar | awk '{print $1}')" \
4242
--data-binary '@target/e2e-test-plugin.jar' \
Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,15 @@
11
package io.github.slimefun.e2etester.tests;
22

3+
import org.bukkit.Bukkit;
4+
35
import io.github.slimefun.e2etester.framework.Assert;
46
import io.github.slimefun.e2etester.framework.annotations.E2ETest;
57

68
public class VersionsTest {
79

810
@E2ETest(description = "Test that `/sf versions` returns the right MC version")
911
public void testMcVersion() {
10-
Assert.runConsoleCommand("sf versions", (output) -> output.contains("MC: 1.20.1"));
12+
Assert.runConsoleCommand("sf versions", (output) -> output.contains("Paper " + Bukkit.getVersion()));
1113
}
1214

1315
@E2ETest(description = "Test that `/sf versions` returns the right SF version")
@@ -17,6 +19,17 @@ public void testSlimefunVersion() {
1719

1820
@E2ETest(description = "Test that `/sf versions` returns the right Java version")
1921
public void testJavaVersion() {
20-
Assert.runConsoleCommand("sf versions", (output) -> output.contains("Java 20"));
22+
// Grab the Java version, if it's still a 1.x strip that and then remove minor so we go from 1.8.1 -> 8
23+
String expectedVersion = System.getProperty("java.version");
24+
if (expectedVersion.startsWith("1.")) {
25+
expectedVersion = expectedVersion.substring(2);
26+
}
27+
int minorVersionIdx = expectedVersion.indexOf('.');
28+
if (minorVersionIdx != -1) {
29+
expectedVersion = expectedVersion.substring(0, minorVersionIdx);
30+
}
31+
32+
final String finalExpectedVersion = expectedVersion;
33+
Assert.runConsoleCommand("sf versions", (output) -> output.contains("Java " + finalExpectedVersion));
2134
}
2235
}

0 commit comments

Comments
 (0)