Sonar fixes

Author: Selinux24

Engine.PathFinding.RecastNavigation/Detour/Tiles/TileCachePolyMesh.cs

@@ -79,7 +79,7 @@ public static TileCachePolyMesh Build(TileCacheContourSet cset, int nvp)
             int[] nextVert = Helper.CreateArray(maxVertices, 0);
             int[] firstVert = Helper.CreateArray(VERTEX_BUCKET_COUNT, NULL_IDX);
 
-            foreach (var (i, cont) in cset.IterateContours())
+            foreach (var (_, cont) in cset.IterateContours())
             {
                 // Skip null contours.
                 int nverts = cont.GetVertexCount();

Engine.PathFinding.RecastNavigation/GraphDebug.cs

@@ -348,7 +348,7 @@ private static IEnumerable<GraphDebugDataCollection> GetContourBorders(ContourSe
             Dictionary<Color4, List<Vector3>> lines = [];
 
             bool empty = true;
-            foreach (var (i, c) in cset.IterateContours())
+            foreach (var (_, c) in cset.IterateContours())
             {
                 if (!c.HasVertices())
                 {
@@ -388,11 +388,11 @@ private static IEnumerable<GraphDebugDataCollection> GetContoursRegions(ContourS
             List<Vector3> lines = [];
 
             // Draw centers
-            foreach (var (i, cont1) in cset.IterateContours())
+            foreach (var (_, cont1) in cset.IterateContours())
             {
                 var pos1 = cont1.GetContourCenter(orig, cs, ch);
 
-                foreach (var (j, v) in cont1.IterateVertices())
+                foreach (var (_, v) in cont1.IterateVertices())
                 {
                     var r = (int)(uint)v.Flag;
 
@@ -889,7 +889,7 @@ private static IEnumerable<GraphDebugDataCollection> GetTileCacheContourBorders(
             Dictionary<Color4, List<Vector3>> lines = [];
 
             bool empty = true;
-            foreach (var (i, c) in cset.IterateContours())
+            foreach (var (_, c) in cset.IterateContours())
             {
                 if (!c.HasVertices())
                 {
@@ -929,11 +929,11 @@ private static IEnumerable<GraphDebugDataCollection> GetTileCacheContoursRegions
             List<Vector3> lines = [];
 
             // Draw centers
-            foreach (var (i, cont1) in cset.IterateContours())
+            foreach (var (_, cont1) in cset.IterateContours())
             {
                 var pos1 = cont1.GetContourCenter(orig, cs, ch);
 
-                foreach (var (j, v) in cont1.IterateVertices())
+                foreach (var (_, v) in cont1.IterateVertices())
                 {
                     var r = (int)(uint)v.Flag;
 

Engine.PathFinding.RecastNavigation/Recast/Heightfield.cs

@@ -138,7 +138,7 @@ public int GetSpanCount()
         {
             int spanCount = 0;
 
-            foreach (var (x, y, s) in IterateSpansWithNexts())
+            foreach (var (_, _, s) in IterateSpansWithNexts())
             {
                 // Skip non walkable spans.
                 if (s.Area == AreaTypes.RC_NULL_AREA)

Engine.PathFinding.RecastNavigation/Recast/PolyMesh.cs

@@ -211,7 +211,7 @@ public static PolyMesh Build(ContourSet cset, int nvp)
             int[] nextVert = Helper.CreateArray(maxVertices, 0);
             int[] firstVert = Helper.CreateArray(VERTEX_BUCKET_COUNT, NULL_IDX);
 
-            foreach (var (i, cont) in cset.IterateContours())
+            foreach (var (_, cont) in cset.IterateContours())
             {
                 // Skip null contours.
                 int nverts = cont.GetVertexCount();

Engine/Collections/Helpers/PickingQuadTreeNodeHelper.cs

@@ -222,7 +222,7 @@ private static bool PickAllNode(PickingQuadTreeNode<T> node, PickingRay ray, out
 
             foreach (var child in node.Children)
             {
-                var inBox = Intersection.RayIntersectsBox(ray, child.BoundingBox, out float d);
+                var inBox = Intersection.RayIntersectsBox(ray, child.BoundingBox, out _);
                 if (!inBox)
                 {
                     continue;

Samples/03 TerrainSamples/SceneModularDungeon/ModularDungeonScene.cs

@@ -904,7 +904,7 @@ private void UpdateEntities()
                 .Where(i => Camera.Frustum.Contains(i.Instance.GetBoundingBox()) != ContainmentType.Disjoint)
                 .Where(i =>
                 {
-                    if (i.Instance.PickNearest(ray, out var res))
+                    if (i.Instance.PickNearest(ray, out _))
                     {
                         return true;
                     }