Code improvements suggested by Clippy 1.90.

Author: partim

src/commons/crypto/signing/dispatch/signerrouter.rs

@@ -782,6 +782,7 @@ impl Signer for SignerRouter {
 
 #[cfg(all(test, feature = "hsm"))]
 pub mod tests {
+    use std::slice;
     use rpki::crypto::RpkiSignatureAlgorithm;
 
     use crate::{
@@ -836,7 +837,7 @@ pub mod tests {
             // Create a SignerRouter that uses the mock signer with the mock
             // signer starting in the pending signer set.
             let router = create_signer_router(
-                &[mock_signer.clone()],
+                slice::from_ref(&mock_signer),
                 signer_mapper.clone(),
             );
 
@@ -901,7 +902,7 @@ pub mod tests {
             // forcing it to re-read it's saved state from disk
             // (and we're not trying to test the AggregateStore here anyway!).
             let router = create_signer_router(
-                &[mock_signer.clone()],
+                slice::from_ref(&mock_signer),
                 signer_mapper.clone(),
             );
 

src/commons/storage/test.rs

@@ -4,6 +4,7 @@
 //! requires a wee bit of macro magic.
 #![cfg(test)]
 
+use std::slice;
 use std::sync::{Mutex, MutexGuard};
 use lazy_static::lazy_static;
 use tempfile::{TempDir, tempdir};
@@ -194,7 +195,7 @@ testfns! {
         assert!(store.scopes().unwrap().is_empty());
 
         store.store(&key, &CONTENT).unwrap();
-        assert_eq!(store.scopes().unwrap(), [scope.clone()]);
+        assert_eq!(store.scopes().unwrap(), slice::from_ref(&scope));
 
         store.store(&key2, &CONTENT_2).unwrap();
 
@@ -205,7 +206,7 @@ testfns! {
         assert_eq!(scopes, expected);
 
         store.drop_scope(&scope2).unwrap();
-        assert_eq!(store.scopes().unwrap(), [scope.clone()]);
+        assert_eq!(store.scopes().unwrap(), slice::from_ref(&scope));
 
         store.drop_scope(&scope).unwrap();
         assert!(store.scopes().unwrap().is_empty());
@@ -247,7 +248,9 @@ testfns! {
         expected.sort();
         assert_eq!(keys, expected);
 
-        assert_eq!(store.keys(&scope, id2.as_str()).unwrap(), [key2.clone()]);
+        assert_eq!(
+            store.keys(&scope, id2.as_str()).unwrap(), slice::from_ref(&key2)
+        );
         assert_eq!(store.keys(&scope, id3.as_str()).unwrap(), []);
         assert_eq!(
             store.keys(&Scope::global(), id3.as_str()).unwrap(),