Skip to content

Commit 321d384

Browse files
authored
Do not include systemd unit files in krillta and krillup (#1313)
This PR prevents older versions of deb packages from including systemd-unit files. Because of the way Krill is set up, this requires both Ubuntu 20.04 and Debian 11 to have usrmerge (which both have by default, only if upgraded from an older version it might be missing).
1 parent 26dabdd commit 321d384

10 files changed

+9
-98
lines changed

Cargo.toml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -236,16 +236,9 @@ assets = [
236236
# OpenSSL >= 1.1.0.
237237
# b) uses a simpler systemd service unit file because Ubuntu 16.04 doesn't
238238
# support newer features supported by Ubuntu 18.04 and 20.04.
239-
[package.metadata.deb.variants.ubuntu-focal]
240-
systemd-units = { unit-name = "krill", unit-scripts = "pkg/common", enable = false, usr-merge = false }
241-
242239
[package.metadata.deb.variants.ubuntu-jammy]
243-
systemd-units = { unit-name = "krill", unit-scripts = "pkg/common", enable = false, usr-merge = false }
244240
depends = "$auto, passwd, libssl3"
245241

246-
[package.metadata.deb.variants.debian-bullseye]
247-
systemd-units = { unit-name = "krill", unit-scripts = "pkg/common", enable = false, usr-merge = false }
248-
249242
[package.metadata.deb.variants.debian-bookworm]
250243
depends = "$auto, passwd, libssl3"
251244

@@ -260,7 +253,6 @@ depends = "$auto, passwd, libssl3"
260253
# on the target platform and so it cannot determine the dependencies correctly
261254
# for us.
262255
[package.metadata.deb.variants.debian-bullseye-armv7-unknown-linux-gnueabihf]
263-
systemd-units = { unit-name = "krill", unit-scripts = "pkg/common", enable = false, usr-merge = false }
264256
depends = "adduser, passwd, libc6 (>= 2.28), libssl1.1"
265257

266258
# END DEBIAN PACKAGING

pkg/common/krill-debian-buster-aarch64-unknown-linux-gnu.krill.service

Lines changed: 0 additions & 1 deletion
This file was deleted.

pkg/common/krill-debian-buster-arm-unknown-linux-gnueabihf.krill.service

Lines changed: 0 additions & 1 deletion
This file was deleted.

pkg/common/krill-debian-buster.krill.service

Lines changed: 0 additions & 1 deletion
This file was deleted.

pkg/common/krill-debian-stretch.krill.service

Lines changed: 0 additions & 1 deletion
This file was deleted.
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
krill-ubuntu-focal.krill.service

pkg/common/krill-ubuntu-bionic.krill.service

Lines changed: 0 additions & 34 deletions
This file was deleted.

pkg/common/krill-ubuntu-xenial.krill.service

Lines changed: 0 additions & 17 deletions
This file was deleted.

pkg/rules/packages-to-build.yml

Lines changed: 8 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -39,29 +39,20 @@ include:
3939
- image: "almalinux:10"
4040
rpm_systemd_service_unit_file: "pkg/common/krill-ubuntu-focal.krill.service"
4141

42+
- image: "debian:bullseye"
43+
deb_extra_lintian_args: "--suppress-tags systemd-service-file-outside-lib"
44+
45+
- image: "ubuntu:focal"
46+
deb_extra_lintian_args: "--suppress-tags systemd-service-file-outside-lib"
47+
4248
# package for the Raspberry Pi 4b as an ARMv7 cross compiled variant of the Debian Bullseye upon which
4349
# Raspbian 11 is based.
4450
- pkg: "krill"
4551
image: "debian:bullseye"
4652
target: "armv7-unknown-linux-gnueabihf"
53+
deb_extra_lintian_args: "--suppress-tags systemd-service-file-outside-lib"
4754
- pkg: "krillup"
4855
image: "debian:bullseye"
4956
target: "armv7-unknown-linux-gnueabihf"
57+
deb_extra_lintian_args: "--suppress-tags systemd-service-file-outside-lib"
5058

51-
# package for the Raspberry Pi 1b as an ARMv6 cross compiled variant of the Debian Buster upon which
52-
# Raspbian 10 is based.
53-
- pkg: "krill"
54-
image: "debian:buster"
55-
target: "arm-unknown-linux-gnueabihf"
56-
- pkg: "krillup"
57-
image: "debian:buster"
58-
target: "arm-unknown-linux-gnueabihf"
59-
60-
# package for the ROCK64 as an AARCH64 cross compiled variant of Debian Buster upon which Armbian 21 is
61-
# based.
62-
- pkg: "krill"
63-
image: "debian:buster"
64-
target: "aarch64-unknown-linux-gnu"
65-
- pkg: "krillup"
66-
image: "debian:buster"
67-
target: "aarch64-unknown-linux-gnu"

pkg/rules/packages-to-test.yml

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -48,24 +48,6 @@ include:
4848
image: "debian:bullseye"
4949
target: "armv7-unknown-linux-gnueabihf"
5050

51-
# package for the Raspberry Pi 1b as an ARMv6 cross compiled variant of the Debian Buster upon which
52-
# Raspbian 10 is based.
53-
- pkg: "krill"
54-
image: "debian:buster"
55-
target: "arm-unknown-linux-gnueabihf"
56-
- pkg: "krillup"
57-
image: "debian:buster"
58-
target: "arm-unknown-linux-gnueabihf"
59-
60-
# package for the ROCK64 as an AARCH64 cross compiled variant of Debian Buster upon which Armbian 21 is
61-
# based.
62-
- pkg: "krill"
63-
image: "debian:buster"
64-
target: "aarch64-unknown-linux-gnu"
65-
- pkg: "krillup"
66-
image: "debian:buster"
67-
target: "aarch64-unknown-linux-gnu"
68-
6951
# Exclude upgrade testing on Ubuntu Noble as no prior released versions exist to upgrade from.
7052
exclude:
7153
- image: "almalinux:9"

0 commit comments

Comments
 (0)