-
Notifications
You must be signed in to change notification settings - Fork 38
Open
Description
The hard-coding of compiler options conflict with options that might be required in parent projects. These should be moved to the configuration stage for testing in this project and/or guarded with an option to allow the parent projects to prevent them from being set if needed.
isobmff/IsoLib/libisomediafile/CMakeLists.txt
Lines 9 to 15 in 7eaf048
| if (MSVC) | |
| # warning level 4 and all warnings as errors | |
| add_compile_options(/W4 /WX) | |
| else() | |
| # lots of warnings and all warnings as errors | |
| add_compile_options(-Wall -Wextra -pedantic -Werror) | |
| endif() |
isobmff/IsoLib/libisomediafile/CMakeLists.txt
Lines 266 to 277 in 7eaf048
| target_compile_options( | |
| ${PROJECT_NAME} | |
| PRIVATE | |
| # GNU compiler | |
| $<$<C_COMPILER_ID:GNU>:-Wall -W -ansi -pedantic -Wno-long-long -Wmissing-prototypes> | |
| # Visual Studio run time library | |
| $<$<AND:$<C_COMPILER_ID:MSVC>,$<CONFIG:Debug>>:/MTd> | |
| $<$<AND:$<C_COMPILER_ID:MSVC>,$<NOT:$<CONFIG:Debug>>>:/MT> | |
| ) |
Metadata
Metadata
Assignees
Labels
No labels