Skip to content

Commit f917fe4

Browse files
committed
clean up typos
1 parent 7965605 commit f917fe4

File tree

3 files changed

+7
-9
lines changed

3 files changed

+7
-9
lines changed

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ implementation which people can learn from.
3636

3737
This code is not constant time, or written to be performant. Rather, it was
3838
written so that the python code closely follows the Kyber specification
39-
[specification](https://pq-crystals.org/kyber/data/kyber-specification-round3-20210804.pdf) and [FIPS 203](https://csrc.nist.gov/pubs/fips/203/final). To cryptographic guarantees are made of this work.
39+
[specification](https://pq-crystals.org/kyber/data/kyber-specification-round3-20210804.pdf) and [FIPS 203](https://csrc.nist.gov/pubs/fips/203/final). No cryptographic guarantees are made of this work.
4040

4141
## History of this Repository
4242

@@ -56,11 +56,11 @@ and [`test_ml_kem.py`](tests/test_ml_kem.py).
5656

5757
The KAT files were either downloaded or generated:
5858

59-
1. For **Kyber**, the KAT files were generated from the projects [GitHub
59+
1. For **ML-KEM**, the KAT files were download from the GitHub repository
60+
[usnistgov/ACVP-Server/](https://github.com/usnistgov/ACVP-Server/releases/tag/v1.1.0.35) release 1.1.0.35, and are included in `assets/ML-KEM-*` directories.
61+
2. For **Kyber**, the KAT files were generated from the projects [GitHub
6062
repository](https://github.com/pq-crystals/kyber/) and are included in
6163
`assets/PQCLkemKAT_*.rsp`
62-
2. For **ML-KEM**, the KAT files were download from the GitHub repository
63-
[usnistgov/ACVP-Server/](https://github.com/usnistgov/ACVP-Server/releases/tag/v1.1.0.35) release 1.1.0.35, and are included in `assets/ML-KEM-*` directories.
6464

6565
**Note**: for Kyber v3.02, there is a discrepancy between the specification and
6666
reference implementation. To ensure all KATs pass, one has to generate the

src/kyber_py/ml_kem/ml_kem.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
class ML_KEM:
1313
def __init__(self, params):
1414
"""
15-
Initialise the ML-KEM with specified lattice parameters
15+
Initialise the ML-KEM with specified lattice parameters.
1616
1717
:param dict params: the lattice parameters
1818
"""

tests/test_ml_kem.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,11 +86,9 @@ def test_decaps_hash_check_failure(self):
8686

8787
class TestML_KEM_KAT(unittest.TestCase):
8888
"""
89-
Test ML_KEM levels for internal
90-
consistency by generating key pairs
91-
and shared secrets.
89+
Test ML-KEM against test vectors collected from
90+
https://github.com/usnistgov/ACVP-Server/releases/tag/v1.1.0.35
9291
"""
93-
9492
def generic_keygen_kat(self, ML_KEM, index):
9593
with open("assets/ML-KEM-keyGen-FIPS203/internalProjection.json") as f:
9694
data = json.load(f)

0 commit comments

Comments
 (0)